Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636041

Miroslav Suchý <msu...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Miroslav Suchý <msu...@redhat.com> 2010-11-01 15:29:07 EDT 
---
python-cairo.src: W: strange-permission py2cairo-1.8.10.tar.gz 0444L
This should be probably 644

python-cairo.src: E: invalid-spec-name
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name
Your spec is named pycairo.spec, whereas you should use python-cairo.spec

not sure, why you use %{cairo_version}, which is the same as %{version}

there is huge list of rpmlint warning such as:
python-cairo.x86_64: W: spurious-executable-perm
/usr/share/doc/python-cairo-1.8.10/examples/cairo_snippets/snippets/set_line_join.py
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.
I would tend to think that files in /usr/share/doc should not have executable
bits sets. But I will not block review on this.

beside mention items it looks good. Please fix at least first two.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to