https://bugzilla.redhat.com/show_bug.cgi?id=1503915
--- Comment #9 from Stuart D Gathman <stu...@gathman.org> --- Spec URL: https://gathman.org/linux/SPECS/roca-detect.spec SRPM URL: https://gathman.org/linux/f28/src/roca-detect-1.2.1-3.fc28.src.rpm Adjusted as requested, except as noted below: 3. As noted above and in SPEC comments, %py_build and %py_install fail. Also, Neal's definition of __python fails, %{__python} gets substituted with a literal "%{__python3}" - causing all kinds of havoc. I compromised and defined it as /usr/bin/python3 (should have used %{_bindir}, but I've spent too long). 4. See 3. 9. The "EASY" introducer supplied by upstream requires setuptools >= 1.0 (doesn't work in epel), requires setuptools at runtime, and is horribly complex compared to a simple wrapper script. The cat is so that the proper python version is easily substituted in. The upstream /usr/bin name is roca-detect-tls. I took the liberty of shortening it. 11. I gave the patch an explicit 0 (is that *really* important?). It is important to me to give the patch backup files an extension that I can easily feed back into gendiff. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
