https://bugzilla.redhat.com/show_bug.cgi?id=1662565
--- Comment #5 from Peter Lemenkov <lemen...@gmail.com> ---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is almost silent:
Auriga ~/rpmbuild/SPECS: rpmlint
../SRPMS/libsignal-protocol-c-2.3.2-1.fc29.src.rpm
../RPMS/x86_64/libsignal-protocol-c-*
libsignal-protocol-c.src: E: description-line-too-long C This is a ratcheting
forward secrecy protocol that works in synchronous and asynchronous messaging
libsignal-protocol-c.x86_64: E: description-line-too-long C This is a
ratcheting forward secrecy protocol that works in synchronous and asynchronous
messaging
^^^ These two looks cosmetic. But anyway consider shortening it.
libsignal-protocol-c-devel.x86_64: W: no-documentation
^^^ It does not contain any docs.
5 packages and 0 specfiles checked; 2 errors, 1 warnings.
Auriga ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (GPLv3
exactly).
+ The file, containing the text of the license(s) for the package, is included
as %license.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
Auriga ~/rpmbuild/SOURCES: sha256sum libsignal-protocol-c-2.3.2.tar.gz*
f3826f3045352e14027611c95449bfcfe39bfd3d093d578c70f70eee0c85000d
libsignal-protocol-c-2.3.2.tar.gz
f3826f3045352e14027611c95449bfcfe39bfd3d093d578c70f70eee0c85000d
libsignal-protocol-c-2.3.2.tar.gz.1
Auriga ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
+/- The package bundle copies of system libraries (protobuf compiler and
curve25519 library, which isn't included in Fedora repos yet). A necessary
provides is added.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ Header files are stored in a -devel package.
0 No static libraries.
+ The pkgconfig(.pc) files are stored in a -devel package and necessary runtime
requirement added automatically.
+ The library file(s) that end in .so (without suffix) is(are) stored in a
-devel package.
+ The -devel package requires the base package using a fully versioned
dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ All filenames in rpm packages are valid UTF-8.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
