https://bugzilla.redhat.com/show_bug.cgi?id=1676914
Josef Skladanka <jskla...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jskla...@redhat.com
--- Comment #6 from Josef Skladanka <jskla...@redhat.com> ---
(In reply to Miro Hrončok from comment #5)
> That comment is a lie. python-flask-cache in Fedora is Flask-Cache, sources
> point to
> https://pypi.python.org/packages/source/F/Flask-Cache/Flask-Cache-0.13.1.tar.
> gz and there are no patches that change it Flask-Caching.
I would not go as far as "lie" (and I'm choosing not to take this as an attack,
but rather an error caused by English not being your first language, and
probably some hasty reading of the comment itself), but you are right that the
comment is probably incomplete/not specific enough.
Nowhere in the comment, I say the python-flask-cache package in fedora uses
flask-caching sources, I'm rather pointing out, that instead of obsoleting
flask-cache, and packaging flask-caching, the Fedora-package uses the `from
flask_cache import` implementation present in flask-caching, instead of the
`from flask.ext.cache import` line present in the git repo/tar.gz release of
flask-cache.
The fact is, that in order for the code to work, when installing deps from PIP,
flask-caching needs to be used, and when used in "fedora environment"
flask-cache needs to be used (because flask-caching is not packaged, and
flask-cache is basically hot-fixed to work with the new-style flask imports by
sed in specfile).
If it will make you happier, I can, of course, change the comment to encompass
all the details, but it does not change the facts of the matter at hand.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
