https://bugzilla.redhat.com/show_bug.cgi?id=1685022
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
- make %{?_smp_mflags} → %make_build
- make install DESTDIR=%{buildroot} → %make_install
- The libraries should be versioned:
%{_libdir}/libHepMC3.so
%{_libdir}/libHepMC3search.so
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning
In cases where upstream ships unversioned .so library (so this is not needed
for plugins, drivers, etc.), the packager MUST try to convince upstream to
start versioning it.
If that fails due to unwilling or unresposive upstream, the packager may start
versioning downstream but this must be done with caution and ideally only in
rare cases. We don’t want to create a library that could conflict with upstream
if they later start providing versioned shared libraries. Under no
circumstances should the unversioned library be shipped in Fedora.
For downstream versioning, the name should be composed like this:
libfoobar.so.0.n
The n should initially be a small integer (for instance, "1"). we use two
digits here ("0.n") because the common practice with upstreams is to use only a
single digit here. Using multiple digits helps us avoid potential future
conflicts. Do not forget to add the SONAME field (see below) to the library.
When new versions of the library are released, you should use an ABI comparison
tool to check for ABI differences in the built shared libraries. If it detects
any incompatibilities, bump the n number by one.
→ Ask upstream to adopt SONAME versioning.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
