https://bugzilla.redhat.com/show_bug.cgi?id=1685270



--- Comment #2 from Gergely Gombos <gomb...@gmail.com> ---
Thanks for the quick review, Robert-André!

Corrected all, except the ZSH part, since it's not a plugin but a deprecated
installation file, not used by install.sh. (A warning is in the file, too)
The official install.sh only installs the main executable + the manpages.

- Source URL corrected
- uses %make_build & %make_install
- removed rm -rf buildroot etc.
- removed debug package nil part (I added it before realizing it was noarch...)

See: https://github.com/sobolevn/git-secret/issues/382

SPEC:
https://pagure.io/git-secret/raw/master/f/git-secret.spec

SRPM:
https://pagure.io/git-secret/raw/master/f/git-secret-0.2.5-2.fc31.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to