https://bugzilla.redhat.com/show_bug.cgi?id=1695362
Georg Sauthoff <fed...@georg.so> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #8 from Georg Sauthoff <fed...@georg.so> ---
I approve this package.
I based my review on the Fedora packaging Guidelines and the relevant packaging
guides.
I noticed that the capitalization in summary/description isn't complete, but
this is just a small thing:
--- python-metaextract.spec.orig 2019-04-05 12:03:04.639424265 +0200
+++ python-metaextract.spec 2019-04-05 12:03:26.524587497 +0200
@@ -1,6 +1,6 @@
%global srcname metaextract
-%global descr metaextract is a tool to collect metadata about a python \
+%global descr Metaextract is a tool to collect metadata about a Python \
module. For example you may have a sdist tarball from the Python Package Index
\
and you want to know it's dependencies. metaextract can collect theses \
dependencies. The tool was first developed in py2pack but is now it's own \
@@ -9,7 +9,7 @@
Name: python-%{srcname}
Version: 1.0.5
Release: 1%{?dist}
-Summary: Metaextract is a tool to collect metadata for python modules
+Summary: Metaextract is a tool to collect metadata for Python modules
License: ASL 2.0
URL: https://github.com/toabctl/metaextract
Attached below the output of fedora-review annotated with some annotations (+,
-, ?).
Package Review
==============
Legend:
[x] = Pass, [!] = Fail,
[-] = Not applicable (manually reviewed)
[?] = Not evaluated
[ ] = Manual review needed
[+] = Passed after manual review
===== MUST items =====
Generic:
[+]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[+]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* Apache License (v2.0)", "Unknown or generated",
"Apache License (v2.0)". 18 files have unknown license. Detailed
output of licensecheck in /home/gms/program/copr-fedora/python-
metaextract/review/review-python-metaextract/licensecheck.txt
[+]: License file installed when any subpackage combination is installed.
[+]: Package contains no bundled libraries without FPC exception.
[+]: Changelog in prescribed format.
[+]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[+]: Package consistently uses macros (instead of hard-coded directory
names).
[+]: Package is named according to the Package Naming Guidelines.
[+]: Package does not generate any conflict.
[+]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[+]: Requires correct, justified where necessary.
[+]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[+]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[+]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[+]: Python eggs must not download any dependencies during the build
process.
[+]: A package which is used by another package via an egg interface should
provide egg info.
[+]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[+]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-metaextract , python-metaextract-doc
[+]: Package functions as described.
[+]: Latest version is packaged.
[+]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[+]: %check is present and all tests pass.
[+]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-metaextract-1.0.5-1.fc29.noarch.rpm
python-metaextract-doc-1.0.5-1.fc29.noarch.rpm
python-metaextract-1.0.5-1.fc29.src.rpm
python3-metaextract.noarch: W: spelling-error %description -l en_US sdist ->
dist, sadist, s dist
python3-metaextract.noarch: W: no-manual-page-for-binary metaextract
python-metaextract.src: W: spelling-error %description -l en_US sdist -> dist,
sadist, s dist
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
python-metaextract-doc.noarch: W: invalid-url URL:
https://github.com/toabctl/metaextract <urlopen error [Errno -2] Name or
service not known>
python3-metaextract.noarch: W: spelling-error %description -l en_US sdist ->
dist, sadist, s dist
python3-metaextract.noarch: W: invalid-url URL:
https://github.com/toabctl/metaextract <urlopen error [Errno -2] Name or
service not known>
python3-metaextract.noarch: W: no-manual-page-for-binary metaextract
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Requires
--------
python-metaextract-doc (rpmlib, GLIBC filtered):
python3-metaextract (rpmlib, GLIBC filtered):
/usr/bin/python3
python(abi)
Provides
--------
python-metaextract-doc:
python-metaextract-doc
python3-metaextract:
python3-metaextract
python3.7dist(metaextract)
python3dist(metaextract)
Source checksums
----------------
https://github.com/toabctl/metaextract/archive/1.0.5/python-metaextract-1.0.5.tar.gz
:
CHECKSUM(SHA256) this package :
218eb4cd11c6a750513e1139e3e5869a8142eced54110d0e5d1b534d22f81df8
CHECKSUM(SHA256) upstream package :
218eb4cd11c6a750513e1139e3e5869a8142eced54110d0e5d1b534d22f81df8
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n python-metaextract
Buildroot used: fedora-29-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
