https://bugzilla.redhat.com/show_bug.cgi?id=1677989



--- Comment #30 from Petr Menšík <pemen...@redhat.com> ---
Thanks. However, there is still copy of all wrap into target directory, copying
there all cpp files not required.

Please remove these lines on line 44-45:
mkdir -p %{buildroot}%{_includedir}/%{name}
cp -a  vcg img wrap %{buildroot}%{_includedir}/%{name}

and change:
rm %{buildroot}%{_includedir}/%{name}/wrap/system/getopt.*
to:
rm %{buildroot}%{_includedir}/%{name}/wrap/system/{getopt,qgetopt}.*

You can test it yourself:
$ fedpkg --release f29 local
$ rpm -qpl x86_64/vcglib-devel*.rpm | grep '\.cpp' | wc -l

Should return 0 in devel package.

To simplify future upgrades, Source URL should contain %{version} instead of
version in url:
Source: https://github.com/cnr-isti-vclab/vcglib/archive/v%{version}.tar.gz

That should be all required for this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to