https://bugzilla.redhat.com/show_bug.cgi?id=1703284
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
Blocks| |177841 (FE-NEEDSPONSOR)
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
- Group: is not used in Fedora
- Should just be 1:
Release: rc1%{?dist}
It's not a rc.
- Buildroot is not used anymore
BuildRoot: %(mktemp -udp %{_tmppath}/%{name}-%{version}%)
- Not needed:
ExclusiveOS: Linux
- The Source: must be a URL
Source:
https://github.com/gluster/nbd-runner/archive/v%{version}/%{name}-%{version}.tar.gz
- Please split you BuildRequires And Requires: one per line
- Add gcc as a BuildRequires
- No: %global debug_package %{nil}
If your package is not generating debug symbols, you need to fimd why and fix
it.
- Use %make_build first:
%build
./autogen.sh
%configure %{?_without_tirpc} %{?_without_gluster}
%make_build
- %{__make} DESTDIR=%{buildroot} install → %make_install
- license files must be included with %license, not %doc:
%license COPYING-GPLV2 COPYING-LGPLV3
- You must add the Release info in your %changelog entry:
* Wed Apr 24 2019 Xiubo Li <xiu...@redhat.com> - 0.3-1
- Not needed this is the default already:
%global _hardened_build 1
You'll also need to find a sponsor. Read
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join
and https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
Also you need to sign the CLA on your FAS page.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
