https://bugzilla.redhat.com/show_bug.cgi?id=1692166
--- Comment #4 from Richard W.M. Jones <rjo...@redhat.com> ---
Most obvious things from a manual review of the spec file. These seem both
complex and unnecessary:
# This readme file may be of some value to developers:
mkdir --parents %{buildroot}%{_docdir}/gnatcoll/xref
cp --preserve=timestamps xref/README.md \
--target-directory=%{buildroot}%{_docdir}/gnatcoll/xref
# Install the license in a directory named after the source package.
mkdir --parents %{buildroot}%{_licensedir}/%{name}
cp --preserve=timestamps COPYING3 \
--target-directory=%{buildroot}%{_licensedir}/%{name}
I would replace them with (in %files):
%doc xref/README.md
%license COPYING3
and get rid of %{_docdir}/gnatcoll in %files devel too.
The %license change is required. The %doc change probably not, but
I would recommend it.
I don't know if the following is needed (because I believe that rpaths are
already
checked by RPM), but I guess it doesn't do any harm. Most likely it can be
deleted:
%check
%{_rpmconfigdir}/check-rpaths
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
