https://bugzilla.redhat.com/show_bug.cgi?id=1712980
Elliott Sales de Andrade <quantum.anal...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(quantum.analyst@g |
|mail.com) |
--- Comment #5 from Elliott Sales de Andrade <quantum.anal...@gmail.com> ---
(In reply to Marc-Andre Lureau from comment #4)
> (In reply to Elliott Sales de Andrade from comment #3)
> > - As noted, you should specify an explicit soversion in %files.
>
> changed to
> %{_libdir}/%{name}.so.0*
>
> > - For a multi-license package, the breakdown should be specified in a
> > comment
> > in the spec.
>
> Like many other projects, libslirp has a main license, BSD-3. But MIT is
> quite prominent too. If you look into details, you have to go in the source
> code. I added SPDX tags on each files. How would you break things down in
> the spec?
>
Just add a comment saying to look at the SPDX tags; no need to overcomplicate
things then.
(In reply to Marc-Andre Lureau from comment #4)
> (In reply to Elliott Sales de Andrade from comment #3)
> > - You don't need Requires on pkgconfig or glib-devel as they are
> > automatically
> > added by the .pc file.
>
> What magic does that? any pointer to doc?
>
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies
> RPM can automatically determine dependencies for most compiled libraries and
> for some scripting languages such as Perl. Automatically determined
> dependencies MUST NOT be duplicated by manual dependencies.
You can check these with rpm -q --provides -p libslirp-4.0.0-1.fc31.x86_64.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
