https://bugzilla.redhat.com/show_bug.cgi?id=1743802



--- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.an...@gmail.com> ---
Thanks Igor, updated spec/srpm:


Spec URL: https://ankursinha.fedorapeople.org/taskopen/taskopen.spec
SRPM URL:
https://ankursinha.fedorapeople.org/taskopen/taskopen-1.1.4-1.fc30.src.rpm


diff --git a/taskopen.spec b/taskopen.spec
index cf08592..f186740 100644
--- a/taskopen.spec
+++ b/taskopen.spec
@@ -6,12 +6,11 @@ Summary:        Script for taking notes and open urls with
taskwarrior
 License:        GPLv2+
 URL:            https://github.com/ValiValpas/taskopen
 Source0:       
https://github.com/ValiValpas/taskopen/archive/v%{version}/%{name}-%{version}.tar.gz
+BuildArch:      noarch

-BuildRequires:  perl
-Requires:       task
-Requires:       perl(JSON)
+BuildRequires: perl-generators

-BuildArch:      noarch
+Requires:       task

 %description
 taskopen allows you to link almost any file, webpage or command to a
@@ -39,7 +38,6 @@ rm -vf doc/html/*.orig


 %install
-rm -rf $RPM_BUILD_ROOT
 %make_install PREFIX=%{_prefix}

 # Wrong location, we'll intall it ourselves
@@ -49,10 +47,11 @@ rm -rfv $RPM_BUILD_ROOT/%{_datadir}/taskopen/doc
 %files
 %doc examples doc/html/
 %{_bindir}/%{name}
-%{_mandir}/man1/taskopen.1.gz
-%{_mandir}/man5/taskopenrc.5.gz
-%{_datadir}/%{name}
+%{_mandir}/man1/taskopen.1.*
+%{_mandir}/man5/taskopenrc.5.*
+%{_datadir}/%{name}/

 %changelog
 * Tue Aug 20 2019 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 1.1.4-1
 - Initial build
+- Update as per review comments:
https://bugzilla.redhat.com/show_bug.cgi?id=1743802

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to