Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652257 Golo Fuchert <packa...@golotop.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |packa...@golotop.de --- Comment #1 from Golo Fuchert <packa...@golotop.de> 2010-11-16 16:54:05 EST --- Some initial comments on the package: - No need to BuildRequire gcc-c++ http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 - %setup -q is sufficient, -n %{name}-%{version} is the standard argument - PREFIX=%{_prefix} would be better than PREFIX=/usr since the standard might be changed one day. - COPYING, ChangeLog and README should be included as %doc, COPYING is a must. - Don't forget to update the icon cache when installing new icons: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
