https://bugzilla.redhat.com/show_bug.cgi?id=1750501
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org |zbys...@in.waw.pl
--- Comment #12 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
Replying to some earlier comments first:
> Unversioned so-files
> --------------------
> fastbit-java: /usr/lib64/fastbit/libfastbitjni.so
That's OK. The file is not in the normal library lookup path.
> - Package does not use a name that already exists.
This is a re-review, so the package obviously exists. fedora-review could be
smarter, but it's not.
When using fedora-review, please remove such comments in the future from it's
output when it is
clear that it is wrong.
> # Main package is BSD; the Bison-generated parsers are GPLv3+ with exceptions;
> # contribs/fbmerge is GPLv2+
> License: BSD and GPLv3+ with exceptions and GPLv2+
This one actually should be changed. A license describes the *binary* package
[1]. In this particular case,
the parser parts can only be included in the package because of the license
exception. As the GPLv3-exception
header says, "you may distribute that work under the terms of your choice".
This is exactly what is happening
here: the authors are distributing fastbit under the BSD license. Please remove
any mention of GPLv3+ from the
License lines.
Also, if fbmerge is GPLv2+, then this doesn't matter for the -devel and -java
subpackages. Their license
is just "BSD".
[1]
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#Does_the_License:_tag_cover_the_SRPM_or_the_binary_RPM.3F
Otherwise, looks OK.
+ package name is OK
+ latest version
+ builds and installs OK
+ fedora-review is happy
+ scriptlets look OK (there are none ;))
+ Provides/Requires/BR look OK
Package is RE-APPROVED. Please fix the license bits when re-importing.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
