https://bugzilla.redhat.com/show_bug.cgi?id=1758487
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
- Add a comment for each patch explaining why they are needed (could be a link
to a bug report or a merge request)
- Group: is not used in Fedora
- Use a better name for your archive:
Source0:
https://github.com/facebookresearch/fastText/archive/v%{version}/%{name}-%{version}.tar.gz
- Not used since Fedora 28:
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig
- Not needed:
%clean
- Not needed:
%defattr(-,root,root,-)
- Use %autosetup -p1 -n fastText-%{version} instead of:
%setup -q -n fastText-%{version}
%patch0 -p1
%patch1 -p1
%patch2 -p1
%patch3 -p1
- In order to avoid unintentional soname bump we forbud globbing the major
soname version, be more specific instead:
%{_libdir}/*.so.*
- Not ok:
%global debug_package %{nil}
You need to find why there is no debug info produced.
The CMakeLists.txt doesn't respect the CXXFLAGS set by %cmake, you need to
patch it to remove what is set here:
set(CMAKE_CXX_FLAGS " -pthread -std=c++11 -funroll-loops -O3 -march=native")
march=native and O3 are notably not ok for Fedora!
diff -up fastText-0.9.1/CMakeLists.txt.orig fastText-0.9.1/CMakeLists.txt
--- fastText-0.9.1/CMakeLists.txt.orig 2019-07-04 13:48:15.000000000 +0200
+++ fastText-0.9.1/CMakeLists.txt 2019-10-06 20:30:26.513646833 +0200
@@ -15,8 +15,6 @@ set (fasttext_VERSION_MINOR 1)
include_directories(fasttext)
-set(CMAKE_CXX_FLAGS " -pthread -std=c++11 -funroll-loops -O3 -march=native")
-
set(HEADER_FILES
src/args.h
src/densematrix.h
- Add dots at the end of your description sentences.
- Build with fPIC instead of removing hardening entirely
%build
export CXXFLAGS="%build_cxxflags -fPIC"
%cmake .
%make_build V=1
- You must install the license file with %license in %files and you should
install the others docs with %doc in %files:
%files libs
%license LICENSE
%doc CODE_OF_CONDUCT.md CONTRIBUTING.md README.md
- You need to BR gcc and gcc-c--:
BuildRequires: gcc
BuildRequires: gcc-c++
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
