Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=653378 --- Comment #3 from Cosimo Cecchi <ccec...@redhat.com> 2010-11-18 08:38:46 EST --- Matthias: thanks for the review! Updated spec: http://people.gnome.org/~cosimoc/gtk-theme-engine-clearlooks-pkg/gtk-theme-engine-clearlooks.spec New SRPM: http://people.gnome.org/~cosimoc/gtk-theme-engine-clearlooks-pkg/gtk-theme-engine-clearlooks-2.91.3-2.fc15.src.rpm Some comments... License: I double-checked and it seems that upstream has no COPYING file at all. We should probably provide a patch for upstream with it and add it to %doc for the next upstream release. Anyway, I assumed the gtk-engines COPYING was valid for this package too, and that's LGPLv2; the source code headers say LGPLv2 too. Where did you find GPLv3 mentioned for this package? Obsoletes: if I understood correctly how spec files work, it's actually required to obsolete gtk3-engines, at least in its current form, as both ship the same libclearlooks.so & friends files. The best approach for this would be probably to provide again a patch for upstream which removes the clearlooks engine from gtk-engines, so we can still package both without conflicts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
