https://bugzilla.redhat.com/show_bug.cgi?id=1767918



--- Comment #4 from Elliott Sales de Andrade <quantum.anal...@gmail.com> ---
Please link the spec *and* srpm directly (no .1 suffixes), or fedora-review
does not work.

You should use the %py3_build and %py3_install macros.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_macros

Man page extensions should be globbed.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

It doesn't look like you run systemd in scriptlets, so you don't need to
Require it.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_dependencies_on_the_systemd_package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to