https://bugzilla.redhat.com/show_bug.cgi?id=1769843
--- Comment #5 from Bastien Nocera <bnoc...@redhat.com> ---
(In reply to Michael Catanzaro from comment #4)
> %{_sysconfdir}/dbus-1/system.d/org.freedesktop.LowMemoryMonitor.conf should
> also use %config
It's not really a configuration file, and shouldn't be modified by users, or
even
administrators.
> I see you added %config for %{_sysconfdir}/low-memory-monitor.conf, but I
> would use %config(noreplace) in case the user chooses to modify it.
I would actually want the file to be replaced to automatically use the new
defaults
set in the package, rather than keep the old ones. So the current tag is
correct for
this file.
> Finally, you still have %{?systemd_requires} where systemd-rpm-macros should
> suffice.
That expands to:
%systemd_requires \
Requires(post): systemd \
Requires(preun): systemd \
Requires(postun): systemd \
%{nil}
Which I think is what we want. Or am I missing something?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
