Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=648053 --- Comment #2 from Michael Schwendt <mschwe...@gmail.com> 2010-11-21 14:54:58 EST --- Run rpmlint on the src.rpm and your built rpms. It's one of the things a packager ought to do. The ReviewGuidelines are not specific to the reviewer(s). ;) > %{_libexecdir}/%{name}/* What package owns %{_libexecdir}/%{name} then? http://fedoraproject.org/wiki/Packaging:UnownedDirectories > I don't think we should use %{optflags} on this one, we don't want > to impact the benchmark. Opinions appreciated. Not using %optflags and hence also creating a bad -debuginfo package doesn't fly. How much overhead do you expect from the code that does the measuring compared with the actual execution time of the system calls? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
