Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=653467 --- Comment #3 from Dan Horák <d...@danny.cz> 2010-11-22 06:11:36 EST --- Fixed issues: - source archive matches upstream c8bbf78fc43f74e14582f4451672e1a521c519a6 libpagemap-0.0.1.tar.gz - dist tag is used - license text is included - proper compiler flags are used - upstream man page is not compressed Remaining issues: - the development library "libpagemap.so" is not installed and included in the -devel subpackage - drop the %doc attribute from the man page, it's done automatically by rpm - rpmlint still complains a bit: libpagemap.x86_64: W: spelling-error Summary(en_US) Pagemap -> Page map, Page-map, Pageant libpagemap.x86_64: W: spelling-error %description -l en_US pagemap -> page map, page-map, pageant libpagemap.src: W: spelling-error Summary(en_US) Pagemap -> Page map, Page-map, Pageant libpagemap.src: W: spelling-error %description -l en_US pagemap -> page map, page-map, pageant => false positives libpagemap.x86_64: W: manual-page-warning /usr/share/man/man1/pgmap.1.gz 1: warning: macro `�' not defined => please check libpagemap-devel.x86_64: W: no-documentation => can be ignored libpagemap-devel.x86_64: W: spurious-executable-perm /usr/include/libpagemap.h => best to use "-m 0644" in the install target in the Makefile, see below These issues should be solved in upstream code: - using "-p" and "-m <perms>" options when installing files is preferred Also increase the release and add a changelog entry summarizing the changes for every package iteration, it's hard to track the changes when not doing so. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
