https://bugzilla.redhat.com/show_bug.cgi?id=1812857
--- Comment #9 from Fabien Boucher <fbouc...@redhat.com> ---
(In reply to Miro Hrončok from comment #7)
> Thanks. I'm running automated checks now.
What tool are you using for that ?
>
> Two more nitpicks:
>
> > touch test/__init__.py
>
> Why is this needed?
>
The Pypi archive does not include that file. It is needed to run unitests.
[root@fedora31-packaging python-ws4py]# tar -tzf ws4py-0.5.1.tar.gz | grep test
ws4py-0.5.1/test/
ws4py-0.5.1/test/test_client.py
ws4py-0.5.1/test/test_frame.py
ws4py-0.5.1/test/test_cherrypy.py
ws4py-0.5.1/test/test_messaging.py
ws4py-0.5.1/test/test_websocket.py
ws4py-0.5.1/test/test_utils.py
ws4py-0.5.1/test/test_logger.py
ws4py-0.5.1/test/test_stream.py
ws4py-0.5.1/test/test_manager.py
> > %{__python3} setup.py test
>
> Upstream uses pytest here, why not use it directly? The build.log says:
>
> + /usr/bin/python3 setup.py test
> running test
> WARNING: Testing via this command is deprecated and will be removed in a
> future version.
>
>
> Also, you can (should?) use %{python3} over %{__python3}.
Using pytest now.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
