https://bugzilla.redhat.com/show_bug.cgi?id=1795068



--- Comment #2 from Fabian Affolter <m...@fabian-affolter.ch> ---
Thanks for your help.

(In reply to Fabio Valentini from comment #1)
> 1) It looks like you're using pypi source tarball. You should be able to
> just use "%{pypi_source}" for that.

Fixed

> 2) You could deduplicate the %descriptions (like I commented on
> python-shodan).

I would like to keep it simple.

> 3) Please use trailing slashes for directories in %files:
> 
> %{python3_sitelib}/%{pypi_name}/
> %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/

Fixed


Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-diskcache.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-diskcache-4.1.0-2.fc31.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to