https://bugzilla.redhat.com/show_bug.cgi?id=1816301
david08...@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david08...@gmail.com
--- Comment #3 from david08...@gmail.com ---
Not a full review, but some comments:
Group: is deprecated, please remove
License should be: GPLv3+
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
Name should probably not include the version:
Name: openfoam
I am not sure whether this is a MUST, but the release should start at 1 and be
bumped whenever you change the spec, without a new release:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_simple_versioning
%defattr(-,root,root,-) isn't needed, please remove
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions
I don't think prefix should be set; it is certainly not allowed to use /opt
Buildroot should not be set:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
'%package -n %{name}-examples' -> '%package examples'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
