https://bugzilla.redhat.com/show_bug.cgi?id=1165275
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
--- Comment #4 from Robert-André Mauchin <zebo...@gmail.com> ---
- Not ok:
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
%{python_sitelib}/*
You must use %{python3_sitelib}/ and be more specific as we forbid globbing the
entire directory
- Group is not used in Fedora
- Not needed:
%defattr(-,root,root,-)
rm -rf %{buildroot}
%clean
rm -rf %{buildroot}
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Python 2 is deprecated, you must package Python 3 only.
- Source0:
https://pypi.python.org/packages/source/c/cloudmonkey/%{tarball_name}-%{version}.tar.gz
→ Source0: %{pypi_source}
- %{__python} setup.py build → %py3_build
- %{__python} setup.py install -O1 --skip-build --root %{buildroot} →
%py3_install
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
