https://bugzilla.redhat.com/show_bug.cgi?id=1805779
Adam Williamson <awill...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |awill...@redhat.com
--- Comment #8 from Adam Williamson <awill...@redhat.com> ---
Re: comment #3 and #4 - this was IMO a clear violation of the packaging
guidelines.
https://fedoraproject.org/wiki/Package_Renaming_Process#Re-review_required
states "The reviewer of the package MUST...check the package for the proper
Obsoletes and Provides (see the naming guidelines for more information.) They
MUST document in the review request that they have done so", and the renaming
policy -
https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages
- states:
"If a package is being renamed without any functional changes, or is a
compatible enough replacement to an existing package (where "enough" means that
it includes only changes of magnitude that are commonly found in version
upgrade changes), provide clean upgrade paths and compatibility with:
Provides: oldpackagename = $provEVR
Obsoletes: oldpackagename < $obsEVR
"
there is no weasel wording in either of those places that makes the Provides:
optional. It is clearly mandatory. Nicolas should not have chosen to leave it
out, and Parag should not have approved the package without it.
Just querying package dependencies is not sufficient to decide that nothing
depends on it (to say nothing of the possibility that external packages do),
because we have other tools and configuration that potentially use package
names and provides, as
https://github.com/fedora-silverblue/issue-tracker/issues/33 shows.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
