https://bugzilla.redhat.com/show_bug.cgi?id=1821330



--- Comment #5 from Fabian Affolter <m...@fabian-affolter.ch> ---
- "curl https://raw.githubusercontent.com/Apipie/apypie/v%{version}/LICENSE -o
LICENSE"

  The license file must be "Source1:" and copied in %prep with something like
"cp -a %{SOURCE1} LICENSE)". I guess that curl would be in the base requirement
but koji doesn't have network access while building packages.

- "%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info"
  I would like to suggest to change it to 
"%{python3_sitelib}/%{pypi_name}-%{version}-py*.egg-info" otherwise there will
be a build error when Python 3.10 is introduced


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to