https://bugzilla.redhat.com/show_bug.cgi?id=1823117



--- Comment #7 from Artur Iwicki <fed...@svgames.pl> ---
Dropping an updated spec with unbundled surgescript.

spec: https://svgames.pl/fedora/opensurge-0.5.1.2-3.spec
srpm: https://svgames.pl/fedora/opensurge-0.5.1.2-3.src.rpm

--

>Source1: CMakeLists.txt
>Why not just package a snapshot release or cherry-pick patches?
I'd argue that taking a file out of a snapshot kinda is a cherry-pick. ;)
Either way, that was mostly needed for linking to surgescript statically, since
the CMakeLists.txt from v.0.5.1.2 doesn't accommodate for that. Now that
surgescript has been unbundled, I dropped this.

>The license tag is "CC-BY and CC-BY-SA and CC0 and Public Domain"
Corrected that.

>Use "%make_build"
Hm, pretty much every Fedora package I've seen uses "make %{?_smp_mflags}".


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to