https://bugzilla.redhat.com/show_bug.cgi?id=1824348

Artur Iwicki <fed...@svgames.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fed...@svgames.pl



--- Comment #2 from Artur Iwicki <fed...@svgames.pl> ---
>Requires: perl
Requiring the "perl" metapackage pulls in a lot of dependencies, many of which
will probably be unused. The Perl Packaging Guidelines say that there's a
generator that will automatically generate "Requires:" for appropriate Perl
modules.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_perl_requires_and_provides

>sed -i '1s|/usr/bin/env perl|/usr/bin/perl|' bowtie2
You might want to use %{_bindir}/perl here instead writing /usr/bin/perl.

>%make_install PREFIX="%{_usr}" DESTDIR="%{buildroot}"
1. Use %{_prefix} instead of %{_usr} here.
2. %make_install already sets up DESTDIR.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to