Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=631964 --- Comment #8 from Steve Traylen <steve.tray...@cern.ch> 2010-11-27 15:25:09 EST --- (In reply to comment #7) > MUSTFIX: > - Include the LICENSE.openpbs file in %doc for both subpackages > > Some additional nitpicking: > - Also consider including the AUTHORS and CHANGES files in %doc > - python-pbs and %{altpython}-pbs subpackages have different Group tags; > might > make sense to put them both into same group. Also, if you use same group, > then you only have to specify Group tag for main package and the subpackage > inherits it automatically. > - %descriptions for both subpackages still refer to 'pbs_python' package name All these comments are valid and should have been trivial for me to have seen.. Thanks. %changelog * Sat Nov 27 2010 Steve Traylen <steve.tray...@cern.ch> 4.3.0-4 - Finish renaming package to python-pbs. rhbz#657027 - Add LICENSE.openpbs and CHANGES files to doc. rhbz#657027 - Consistantly group altpython package in same group. http://cern.ch/straylen/rpms/pbs_python/python-pbs.spec http://cern.ch/straylen/rpms/pbs_python/python-pbs-4.3.0-4.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
