https://bugzilla.redhat.com/show_bug.cgi?id=1824848
Petr Viktorin <pvikt...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pvikt...@redhat.com
--- Comment #14 from Petr Viktorin <pvikt...@redhat.com> ---
The:
%{python3_sitelib}/tests
in %files means you're installing the tests system-wide, so `import test` will
import tests of jc. If another package would also try to do this, it would
conflict.
I think you should leave the tests out of the RPM. If you really need them,
could you rename them to e.g. `test_jc`?
Could you include a LICENSE file? Usually it's done like this:
%files -n ...
%doc README.md
%license LICENSE.md
%{_bindir}/jc.md
...
And of course, the license should be included in the archive on PyPI. Otherwise
it's basically illegal to redistribute the package: if you read the MIT
license, you'll find that it basically says you need to distribute the license
(specific parts of it) with the software.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
