https://bugzilla.redhat.com/show_bug.cgi?id=1823132

aegor...@redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(fed...@svgames.pl
                   |                            |)



--- Comment #6 from aegor...@redhat.com ---
I'm sorry for not pointing it in the initial review comment. There is one more
problem pointed by rpmlint.

- $ rpmlint RPMS/x86_64/gearhead1-textmode-1.310-4.fc31.x86_64.rpm
  ...
  gearhead1-textmode.x86_64: E: statically-linked-binary
/usr/libexec/gearhead1/gearhead1-textmode
  ...
 
https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries


Also there are more mixed-use-of-spaces-and-tabs warnings.

- $ rpmlint SRPMS/gearhead1-1.310-4.fc31.src.rpm
  ...
  gearhead1.src:153: W: mixed-use-of-spaces-and-tabs (spaces: line 153, tab:
line 153)
  ...
  after fixing this "spaces and tabs" warning please run rpmlint again, I saw
that there is more places like that


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to