https://bugzilla.redhat.com/show_bug.cgi?id=1839542



--- Comment #2 from Fabian Affolter <m...@fabian-affolter.ch> ---
(In reply to Lyes Saadi from comment #1)
> Tests fail on mock because pycodestyle, pyflakes, pylint and flake8 are
> missing.

This is the reason why I limited the tests. Guidelines say not to run lintings
and alike.

%check
# Not running the lint test
%{__python3} tests/test_scan_testdata.py


> And since test_scan_testdata do not run because there's no internet
> connection, only coding style tests are running, which raises the question
> of relevancy of those tests...

The tests only run if the env var RUN_ONLINETESTS is set as upstream uses a
decorator (@unittest.skipUnless(os.environ.get("RUN_ONLINETESTS")) to skip it.
Thus, the tests should not run on mock. At least in Koji, they don't.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to