https://bugzilla.redhat.com/show_bug.cgi?id=1844643
Alexander Ploumistos <alex.ploumis...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(alex.ploumistos@g |
|mail.com) |
--- Comment #2 from Alexander Ploumistos <alex.ploumis...@gmail.com> ---
Thanks for taking this Gergely (or do you prefer Greg?)
(In reply to Gergely Gombos from comment #1)
> - Qwt License 1.0 should be "LGPLv2+ with exceptions" according to the
> https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
> (Bundled COPYING file is LGPLv2.1 with exceptions.)
I will get it fixed.
> - Feedback needed: qt5-qtbase looks to be required for this package to
> function.
> It owns %{_qt5_docdir}. If it is required anyway, then you "should not" own
> that
> directory. How do you see this?
I was confused about this when I was looking at the other versions of qwt he
have in Fedora, e.g.
https://src.fedoraproject.org/rpms/qwt/blob/master/f/qwt.spec
Rex Dieter writes in his spec file that he takes ownership of the directory in
order to avoid installing other qt or qt-doc dependencies. I don't know what
you might have installed on your systems, but looking at mine, it seems that
QtX applications dump everything under /usr/share/qtX/ and you end up with
files from multiple packages in the same folder.
Personally, I don't mind not owning the directory and adding another
dependency. I will try it like that.
> - You could set "master" to e.g. a "branch" macro, it is used everywhere in
> the specfile,
> and it is not a static value.
I couldn't come up with anything descriptive enough for a mcaro name that would
save me some characters… The upstream of this fork is not going to publish a
versioned release, so until they move to Qwt6, it's always going to be
"master", only the commit tags will change - if they commit anything else ever
again.
> - Maybe you could add to the -doc description that it's HTML documentation?
Will do.
> [!]: Package consistently uses macros (instead of hard-coded directory
> names).
Other than "master", have I forgotten something else?
> [!]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 30720 bytes in 2 files.
What's wrong here?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
