https://bugzilla.redhat.com/show_bug.cgi?id=1839479



--- Comment #2 from Mohamed El Morabity <pikachu.2...@gmail.com> ---
Many thanks for this review ;)

(In reply to Fabian Affolter from comment #1)
> At the moment there is no binary eggs in the source but I suggest to add the
> removal to %prep in case in a future update ther eis one and not to forget
> it.
And you're right ;). This will be fixed at import, as usual ;).


> The removal of some extensions, is OK from my point of view.
> opencensus-ext-mysql is the only one that has its dependency present and
> perhaps could be enabled.
Good catch, I enabled the extension on my side, by fixing the corresponding
setup.py, and it seems to work.
> - contrib/opencensus-ext-postgresql
>   Issue: >= 0.8.dev0, current 0.7.7
>   Dep: https://src.fedoraproject.org/rpms/python-psycopg2, would require a
> patch for the setup.py
It works also, as for the mysql extension (by fixing requirement to psycopg2).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to