https://bugzilla.redhat.com/show_bug.cgi?id=1843751

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com
         Depends On|                            |1851120



--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
 - Group is not used in Fedora

 - Consider splitting the BR and RR one per line

 - You should us the %cmake macro instead of:

export CFLAGS="${RPM_OPT_FLAGS}"
export CXXFLAGS="${RPM_OPT_FLAGS}"
# Fedora says we shouldn't put files in /usr/local/.
mkdir objdir && cd objdir && \
cmake .. \
  -DCMAKE_INSTALL_LIBEXECDIR=%{_libexecdir} \
  -DCMAKE_INSTALL_BINDIR=%{_bindir} \
  -DCMAKE_INSTALL_DATADIR=%{_datadir} \
  -DCMAKE_BUILD_TYPE=$BUILD_TYPE && \


It sets Fedora build flags and some default. (See rpm --eval "%{cmake}")

 - make %{?_smp_mflags} VERBOSE=1 → %make_build VERBOSE=1

 - Release must start as 1 in Fedora

Release: 1%{?dist}

 - Use a better name for your archive:

Source:
https://github.com/marxin/cvise/archive/v%{version}/%{name}-%{version}.tar.gz

 - Build fails:

DEBUG util.py:621:  No matching package to install: 'python3-pebble'

It seems python-pebble was not built on Rawhide:
https://bugzilla.redhat.com/show_bug.cgi?id=1851120



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1851120
[Bug 1851120] No package builds for rawhide?
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to