Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=649425 Tom "spot" Callaway <tcall...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcall...@redhat.com AssignedTo|nob...@fedoraproject.org |tcall...@redhat.com Flag| |fedora-review+ --- Comment #2 from Tom "spot" Callaway <tcall...@redhat.com> 2010-12-02 11:16:37 EST --- Review ======= Good: - rpmlint checks return: kaudiocreator.x86_64: W: no-manual-page-for-binary kaudiocreator Safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on F-14 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file OK == Notes == * BuildRequires: gtk2 seems wrong. I did a scratch build without it (http://koji.fedoraproject.org/koji/taskinfo?taskID=2639728) and it built fine (as expected). You should remove it from your final package. * %clean is unnecessary in active Fedora targets, see: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean (it is still needed if you need this package for EPEL) * BuildRoot is unnecessary in active Fedora targets, see: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag (it is still needed if you need this package for EPEL) * It is no longer necessary to delete the buildroot as the first step of %install in active Fedora targets. It is still needed if you need this package for EPEL. These items are relatively minor, so I won't hold the review up on them. APPROVED. (If you could do a review on 656010, I would appreciate it, shouldn't be too rough.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
