https://bugzilla.redhat.com/show_bug.cgi?id=1853617
--- Comment #1 from Robert-André Mauchin 🐧 <zebo...@gmail.com> ---
%package doc
Summary: RTKLIB manual
Requires: %{name}%{?_isa} = %{version}-%{release}
%description doc
Manual for RTKLIB tools.
- The doc subpackage should be noarch and no isa needed then
-
Source0:
https://github.com/tomojitakasu/RTKLIB/tarball/%{gitcommit_full}
→
Source0:
https://github.com/tomojitakasu/RTKLIB/archive/%{gitcommit_full}/%{name}-%{gitcommit}.tar.gz
- This is not clear how you generated the patch:
# https://github.com/JensReimann/RTKLIB/tree/rtklib_2.4.3
# ceb8106d53afa44cad6c45ae7873ba85ca458dc5
Patch0: rtklib-qt.patch
The commit you mention is totally different from the content of the patch. If
possible get the patch from a pull request or commit URL.
- setup should be quiet:
%setup -q
- keep timestamps with "install -p"
- I would split the library from the binaries by creating a libs subpackage
containing %{_libdir}/libRTKLib.so.1*. Devel should thus Requires:
%{name}-libs%{?_isa} = %{version}-%{release}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
