Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551274

Dmitrij S. Kryzhevich <kr...@land.ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kr...@land.ru

--- Comment #27 from Dmitrij S. Kryzhevich <kr...@land.ru> 2010-12-03 07:12:00 
EST ---
Thomas, if you want to make request instead of Mario Ceresa, you should open
new bug entry and mark this one as dublicate.

But befor you'l do that:
You not need to mark boost as Requires, as it akonadi dependece.
You not need to mark akonadi as Requires, as you have akonadi-devel in
BuilRequires and it will be added automaticaly.
It does not compiled on my F14 machine. Logs: http://fpaste.org/KCco/
You not need to define BuildRoot tag on current Fedora releases until you want
this package in EPEL.
You not need %clean section on current Fedora releases until you want this
package in EPEL.
You not need rm -rf of buildroot in the begin of %install section on current
Fedora releases until you want this package in EPEL.

Just common sence: I don't think it is a good idea to use first person in
description (I highly recommend... and so on).

And I will take thise review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to