https://bugzilla.redhat.com/show_bug.cgi?id=1856557
Fabio Valentini <decatho...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |decatho...@gmail.com
Assignee|nob...@fedoraproject.org |decatho...@gmail.com
Flags| |fedora-review?
--- Comment #2 from Fabio Valentini <decatho...@gmail.com> ---
Taking this review.
One blocking issue right away: The latest version seems to be 217.21, the
package is for 217.8 right now. Can you update it to the latest version?
https://github.com/jenkinsci/trilead-ssh2/releases
Also, the versioning scheme is very weird here (both upstream and in the
package).
Maybe do something like this instead? The "patch level" definitely shouldn't be
in the Release tag. I'd say that ".jenkins" shouldn't be part of the Release
tag, either, since it has nothing to do with the versioning, but with the
origin of the sources.
%global upstream_version 217
%global patch_level 21
Version: %{upstream_version}.%{patch_level}
Release: 1%{?dist}
Source0:
https://github.com/jenkinsci/%{name}/archive/%{name}-build%{upstream_version}-jenkins-%{patch_level}.tar.gz
%setup -q -n %{name}-%{name}-build%{upstream_version}-jenkins-%{patch_level}
A comment in the .spec file that the package is built from the Jenkins fork of
trilead-ssh2 (and why?) is enough.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
