https://bugzilla.redhat.com/show_bug.cgi?id=1853081

Artur Iwicki <fed...@svgames.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fed...@svgames.pl



--- Comment #3 from Artur Iwicki <fed...@svgames.pl> ---
>Source: mlxbf-bfscripts.tar.gz
Ideally this should be a downloadable URL. Are you using the "3.0.beta1" git
tag? Then you could use
"https://github.com/Mellanox/bfscripts/archive/3.0.beta1/bfscripts-3.0.beta1.tar.gz";
here.

>%{__install} bfbootmgr        %{installdir}
>%{__install} man/bfbootmgr.8  %{man8dir}
>...
1. Macro forms of system executables are discouraged.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
2. Use the "-p" flag to preserve timestamps.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to