https://bugzilla.redhat.com/show_bug.cgi?id=1868991
--- Comment #2 from Fabio Valentini <decatho...@gmail.com> ---
(In reply to Mat Booth from comment #1)
> Issues:
>
> 1)
>
> Missing obsoletes/provides -- package does not obsolete/provide
> glassfish-el-api, even though it ships both api and impl jars. The package
> you are renaming split the impl and api into separate sub-packages, was the
> consolidation into a single binary RPM here intentional?
No, that was not intentional. I missed it when creating a clean package from
scratch.
I'll build with `%mvn_build -s` and add an -api subpackage.
> 2)
>
> Incorrect aliases -- it looks like you added "org.glassfish:javax.el" as an
> alias for the API jar, when it should be an alias for the impl jar. For
> example, comparing the old glassfish-el{,-api} packages:
>
> $ xmvn-resolve org.glassfish:javax.el
> /usr/share/java/glassfish-el.jar
> $ xmvn-resolve org.glassfish:javax.el-api
> /usr/share/java/glassfish-el-api.jar
>
> With your new package:
>
> # xmvn-resolve org.glassfish:javax.el
> /usr/share/java/jakarta-el/jakarta.el-api.jar
> # xmvn-resolve org.glassfish:javax.el-api
> ERROR: Unable to resolve artifact org.glassfish:javax.el-api:jar:SYSTEM
>
> So the "org.glassfish:javax.el" alias has different, incompatible behaviour.
Good catch. I'll re-check the artifact coordinates in glassfish-el and
glassfish-el-api and map them to the new artifact coordinates (correctly this
time, I hope).
> I assume once again the aliases you omitted are not required by anything
> currently in Fedora :-)
Yes. Any aliases I dropped were not depended on by anything.
But I will check that again, too, since I clearly was tired when I made this
package :-)
Thanks for the first review, I'll update files and come back here once I' ve
fixed the issues.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
