https://bugzilla.redhat.com/show_bug.cgi?id=1871345



--- Comment #3 from Fabio Valentini <decatho...@gmail.com> ---
(In reply to Jerry James from comment #2)
> The issues are not blocking issues, so this package is APPROVED.

Awesome, thanks for the fast review!

> Issues:
> =======
> - Version 2.0.0 is the latest version
> 
> - The missing test classes are in https://github.com/eclipse-ee4j/metro-saaj
>   with different package names (but maybe I'm looking at mismatched
> versions).

This is why I noted this in the bug description:

> Note 2: For the initial package, version 1.4.2 is targeted while 2.0.0 has 
> been released upstream, because 2.0.0 requires a version of 
> jakarta-activation that has not been released yet (2.0.0).

So I'm going to update the involved packages once all dependencies are there.

>   Would it be worth leaving a note in this spec file that the tests can be
>   enabled if we get metro-saaj packaged for Fedora?

That's good detective work! I'll add a comment that an "saaj-impl" provider is
missing for the tests.

Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to