https://bugzilla.redhat.com/show_bug.cgi?id=1860064



--- Comment #5 from Bastien Nocera <bnoc...@redhat.com> ---
(In reply to Robert-André Mauchin 🐧 from comment #4)
> URL:            https://gitlab.freedesktop.org/pwithnall/libglib-testing
> 
> →
> 
> URL:            https://gitlab.gnome.org/pwithnall/libglib-testing

Fixed.

>  - Not needed anymore except EPEL7:
> 
> %ldconfig_scriptlets

Fixed.

>  - In order to avoid unintentional soname bump, we recommend not globing the
> major soname version:
> 
> %{_libdir}/libglib-testing-0.so.0*

Fixed.

>  - Split this at 80 characters as the package name extends by that:
> 
> %description devel
> This package contains the pkg-config file and development headers
> for %{name}.

Done.

>  - All minor things, so this package is approved but don't forget to fix the
> aforementioned issues before import.

Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to