https://bugzilla.redhat.com/show_bug.cgi?id=1871997
--- Comment #2 from Lyes Saadi <fed...@lyes.eu> ---
Thank you for the quick review! I'll make sure to address all of these ;)!
> - Try to use Fedora flag for %py3_install:
>
> %install
> CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" LDFLAGS="${LDFLAGS:-${RPM_LD_FLAGS}}" \
> %{__python3} setup.py install --root=%{buildroot}
> rm -rfv
> /home/bob/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64/usr/bin/__pycache__
Good idea! I tried using the standard method for building python packages, but
all my attempts failed so miserably, that I just gave up and ended up using the
same method as the old maintainer and totally forgot about build flags!
(Also, I should try to avoid using `/home/bob` :P!)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
