https://bugzilla.redhat.com/show_bug.cgi?id=1874058
Artur Iwicki <fed...@svgames.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fed...@svgames.pl
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Artur Iwicki <fed...@svgames.pl> ---
>%global logiops %{name}
What's this for?
>Source0: https://github.com/PixlOne/logiops/archive/6d7d91c.zip
The project seems to mark releases with git tags. You can fetch a specific tag
from GitHub. Switch the Source URL to:
https://github.com/PixlOne/logiops/archive/%{version}/logiops-%{version}.zip
>ExclusiveArch: x86_64
Why? I took a brief peek at the GitHub repo and didn't see anything saying that
it won't work on other architectures.
>%global debug_package %{nil}
This is generally a red flag. We want debuginfo in Fedora packages. Remove
this.
>mkdir build
>cd build
>cmake ..
Use the %{cmake} macro instead. It will handle setting up CXXFLAGS (which
should enable debuginfo generation) and also create the build directory
("%{__cmake_builddir}").
>cd build
>make
Use %{cmake_build} instead.
>install -d -m 755 %{buildroot}%{_bindir}
>cp -a build/logid %{buildroot}%{_bindir}
>install -d -m 755 %{buildroot}%{_exec_prefix}/lib/systemd/system/
>cp -a build/logid.service %{buildroot}%{_exec_prefix}/lib/systemd/system/
Try using %{cmake_install} instead?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
