Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661810 --- Comment #2 from Hans de Goede <hdego...@redhat.com> 2010-12-09 14:01:58 EST --- Some initial comments / things to fix (which make doing a full review a bit hard): You've the following defattr line in the spec file (multiple times): %defattr(-,root,root.-) That should be: %defattr(-,root,root,-) The: %doc COPYING README Line should be part of the %files for the main package, iow make the main %files look like this: %files %defattr(-,root,root,-) %doc COPYING README %{_libdir}/libcacard.so.* And remove the %doc line further below In %files devel I see: %{_libdir}/libcacard.*a In Fedora we do not ship .la nor .a files, please remove those (see /etc/rpmdevtools/spectemplate-minimal.spec ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
