https://bugzilla.redhat.com/show_bug.cgi?id=1884255
--- Comment #2 from Miro Hrončok <mhron...@redhat.com> --- Spec sanity =========== > License: GNU GPLv2 or later This is not a valid license tag, see https://fedoraproject.org/wiki/Licensing:Main#SoftwareLicenses That should be: License: GPLv2+ BTW upstream says GPLv2+ everywhere, but uses the 'License :: OSI Approved :: GNU General Public License v3 or later (GPLv3+)' classifier. Could you please contact them about the confusion? > %{?python_provide:%python_provide python3-%{pypi_name}} If you target Fedora 33+ only, you don't need this. If you target older releases, you should use https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro instead. > # Remove bundled egg-info > rm -rf %{pypi_name}.egg-info This is most likely not needed. > %{__python3} setup.py test Please, use %{python3} rather than %{__python3}. > %{python3_sitearch}/%{pypi_name} > %{python3_sitearch}/%{pypi_name}-%{version}-py%{python3_version}.egg-info Please add trailing slashes to assert those are directories: %{python3_sitearch}/%{pypi_name}/ %{python3_sitearch}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
