https://bugzilla.redhat.com/show_bug.cgi?id=1878574



--- Comment #2 from Tulio Magno Quites Machado Filho <tul...@ascii.art.br> ---
(In reply to Robert-André Mauchin 🐧 from comment #1)
> [!]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.

A patch has been submitted upstream:
https://github.com/jwiegley/emacs-async/pull/133

> Try to ask upstream for a separate license file.
> 
> [!]: Spec use %global instead of %define unless justified.
>      Note: %define requiring justification: %define pkg async
> 
> Use %global instead of %define here.

Fixed.

>  - Patch these obsolete FSF address with the latest one and send it upstream
> 
> emacs-async.noarch: E: incorrect-fsf-address
> /usr/share/emacs/site-lisp/async/async-bytecomp.el
> emacs-async.noarch: E: incorrect-fsf-address
> /usr/share/emacs/site-lisp/async/async-test.el
> emacs-async.noarch: E: incorrect-fsf-address
> /usr/share/emacs/site-lisp/async/async.el
> emacs-async.noarch: E: incorrect-fsf-address
> /usr/share/emacs/site-lisp/async/dired-async.el
> emacs-async.noarch: E: incorrect-fsf-address
> /usr/share/emacs/site-lisp/async/smtpmail-async.el

Fixed.

The new spec file is available here:
https://pagure.io/emacs-async/blob/master/f/emacs-async.spec

I've also requested the repository.

Thank you!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to