https://bugzilla.redhat.com/show_bug.cgi?id=1887621
--- Comment #9 from Neal Gompa <ngomp...@gmail.com> ---
(In reply to Michel Alexandre Salim from comment #8)
> (In reply to Neal Gompa from comment #6)
> > (In reply to Davide Cavalca from comment #4)
> > >
> > > About the static libraries: folly doesn't have a stable ABI, by design, so
> > > it doesn't seem useful to build shared libraries for it
> >
> > There are a couple of issues with not producing shared libraries:
> >
> > * debuginfo subpackages aren't really possible to generate properly with
> > only static libraries
>
> yeah, debuginfo is disabled for now for folly. Is the concern that packages
> built against folly also can't have proper debuginfo?
>
It is potentially problematic, yeah.
> > * it makes it difficult to track things that need to be rebuilt if folly was
> > updated
>
> Per policy they're supposed to BR folly-static -- so just searching for
> those and rebuilding should be fine, right?
>
In theory, yes. I don't know if anyone has built any automation for that,
though. Most of our automation is built around detecting when the runtime
dependency breaks to detect a need for rebuilds.
> >
> > A suggestion for shared libraries support: you can do something like having
> > the soname change with version bumps to match ABI policy
>
> I suppose we can rename the *.so files manually to *.so.%{flattenedversion}
> - though we will have to patch the build system to allow building both
> static and dynamic libs in one pass.
>
You'd want to adjust the build script to set the soversion to match version.
Otherwise the generated dependency would be broken or otherwise wrong.
You can see an example of how this was done with Google Test (which has similar
issues):
https://src.fedoraproject.org/rpms/gtest/blob/master/f/gtest-1.8.1-libversion.patch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
