https://bugzilla.redhat.com/show_bug.cgi?id=1891963

Michel Alexandre Salim <mic...@michel-slm.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mic...@michel-slm.name
           Assignee|nob...@fedoraproject.org    |mic...@michel-slm.name
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?



--- Comment #1 from Michel Alexandre Salim <mic...@michel-slm.name> ---
Taking this review.

fedora-review crashes on this for some reason, so let's start this manually
first

fedora/reviews/1891963-python-TestSlide 
❯ rpmlint results/python3-TestSlide-2.6.1-1.fc34.noarch.rpm              
python3-TestSlide.noarch: W: spelling-error %description -l en_US unittest ->
unit test, unit-test, unities
python3-TestSlide.noarch: W: spelling-error %description -l en_US TestCase ->
Test Case, Test-Case, Test-case
python3-TestSlide.noarch: W: spelling-error %description -l en_US refactoring
-> re factoring, re-factoring, factorizing
python3-TestSlide.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/testslide/import_profiler.py 644 /usr/bin/env
python3
python3-TestSlide.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/testslide/lib.py 644 /usr/bin/env python3
python3-TestSlide.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/testslide/matchers.py 644 /usr/bin/env python3
python3-TestSlide.noarch: W: no-manual-page-for-binary testslide
1 packages and 0 specfiles checked; 3 errors, 4 warnings.

These are likely not meant to be executed directly, perhaps remove the
shebangs. Spelling errors can be ignored, manpage -- would be nice to request
this from upstream but not a blocker.

spec:
BuildRequires:  python3dist(setuptools)
BuildRequires:  python3dist(setuptools) >= 38.6

this is redundant, you just need the second line

Both docs and tests require make, but it's only a BR for docs


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to